Fix Exercise 3.4 solution to count consecutive wrong passwords

[martin-henz]

Fixes a logic error in the Exercise 3.4 solution (xml/chapter3/section1/subsection1.xml), reported by GitHub user KrNor in #1138.

Problem

Exercise 3.4 asks to call call_the_cops after seven consecutive accesses with an incorrect password. The solution counted total failed attempts and never reset, so a correct access in between still accumulated toward the limit.

Fix

Reset the counter on a correct password:

if (p === q) {
    invalid_attempts = 0; // reset after a correct password
    return ...

Checks (simulated in Node)

• The existing hidden example (eight consecutive wrong attempts) still escalates to call_the_cops, so the snippet's <EXPECTED> value is unchanged.
• After a correct password, six further wrong attempts no longer trigger the cops — whereas under the old total-counting logic they would have. Confirms consecutive counting now works.
• XML well-formed.

Note: the issue also suggested adding a commented-out successful request to the example. I left the example as-is — it's a hidden test snippet with an <EXPECTED> value, so a commented line wouldn't be visible to readers and would break <EXPECTED> if uncommented. Happy to add a proper reset-demonstrating example if you'd prefer.

Closes #1138

[gemini-code-assist]

Code Review

This pull request adds a reset for invalid_attempts to 0 upon a correct password entry in the dispatch function. However, a logic bug was identified where a user is locked out on their 8th attempt even if they enter the correct password, because the check invalid_attempts < 7 prevents the password from being verified once the limit is reached. A restructuring of the function is suggested to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.