Generating unit test command not working #7740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add more tests cases, e.g. for WSL, opening files which are not normal files (e.g. from JARs) etc. |
pkukielka
reviewed
Apr 15, 2025
| val uri = CodyFileUri.parse(uriString) | ||
| val path = uri.toPath() ?: return null | ||
| if (!path.exists()) { | ||
| path.parent?.createDirectories() |
There was a problem hiding this comment.
What if path is relative?
There was a problem hiding this comment.
For the test, can you also open untitled file in VSC and try to do some edit in it?
added 2 commits
April 17, 2025 16:27
…th-norm # Conflicts: # jetbrains/src/main/kotlin/com/sourcegraph/cody/config/actions/OpenCodySettingsEditorAction.kt # jetbrains/src/main/kotlin/com/sourcegraph/utils/CodyEditorUtil.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class that attempts to normalize all the Uri with file paths that we get from the agent. Non-standard formatted uri causes inability to create file in editor (ex. file with unit tests). In addition, the editor does not support the creation of new files in memory by which the use of the prefix untitled in uri was incorrectly interpreted as a request to create a scratchpad file. This PR causes that if the agent request that a file needs to be created, it will be created as a project file (not a scratch file).
Test plan