Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 7, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Jan 7, 2026

🤖 Augment PR Summary

Summary: This PR vendors Octue’s Power Curve JSON Schema version v1.0.0.alpha-4 into the registry.

Changes:

  • Added a new dependency entry for public/octue-power-curve/v1.0.0.alpha-4 in DEPENDENCIES.
  • Introduced a corresponding vendor directory under vendor/public/octue-power-curve/v1.0.0.alpha-4/.
  • Included the upstream LICENSE (CC0 1.0 Universal) for the vendored content.
  • Added a .mask file to exclude non-registry artifacts (docs, tests, tooling files, etc.).

Technical Notes: The schema is authored for JSON Schema draft 2020-12 and is vendored as a single schema.json under power-curve-schema/.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

},
{
"$comment": "Linear ramp down in low temperatures, air density 0.9",
"air_density": 1.225,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the thermal derating examples, the entry commented as “air density 0.9” has "air_density": 1.225, which looks inconsistent and could confuse users relying on the examples.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

"exclusiveMaximum": 30
},
"number_of_blades": {
"type": "number",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turbine.number_of_blades is typed as number, which would validate fractional blade counts; is this intended, or should it be constrained to integers to match the real-world domain?

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@jviotti jviotti merged commit 2a67509 into main Jan 7, 2026
4 checks passed
@jviotti jviotti deleted the power-curve branch January 7, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants