Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full Swift concurrency support with Sendable requirements #92

Merged
merged 12 commits into from
Dec 27, 2024

Conversation

ns-vasilev
Copy link
Member

No description provided.

@ns-vasilev ns-vasilev self-assigned this Dec 26, 2024
@spacecode-github-bot
Copy link

spacecode-github-bot commented Dec 26, 2024

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 90.95477% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.48%. Comparing base (8f6b827) to head (4d4d09e).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...viders/SystemInfoProvider/SystemInfoProvider.swift 44.44% 5 Missing ⚠️
Sources/Flare/Classes/Flare.swift 60.00% 2 Missing ⚠️
...re/Classes/Providers/IAPProvider/IAPProvider.swift 77.78% 2 Missing ⚠️
...re/Classes/Helpers/PaymentQueue/PaymentQueue.swift 80.00% 1 Missing ⚠️
Sources/Flare/Classes/IFlare.swift 0.00% 1 Missing ⚠️
.../Classes/Models/Internal/SK2StoreTransaction.swift 0.00% 1 Missing ⚠️
.../Providers/PurchaseProvider/PurchaseProvider.swift 0.00% 1 Missing ⚠️
...viders/RedeemCodeProvider/RedeemCodeProvider.swift 0.00% 1 Missing ⚠️
...sts/UnitTests/Providers/PaymentProviderTests.swift 97.14% 1 Missing ⚠️
...viders/SortingProductsProviderDecoratorTests.swift 90.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
+ Coverage   70.94%   71.48%   +0.54%     
==========================================
  Files         318      319       +1     
  Lines        7247     7226      -21     
==========================================
+ Hits         5141     5165      +24     
+ Misses       2106     2061      -45     
Files with missing lines Coverage Δ
Sources/Flare/Classes/Common/Logger.swift 87.10% <ø> (ø)
...lare/Classes/Extensions/SKRequest+Identifier.swift 100.00% <ø> (ø)
...ces/Flare/Classes/Helpers/Async/AsyncHandler.swift 100.00% <100.00%> (ø)
...elpers/PaymentTransaction/PaymentTransaction.swift 88.89% <ø> (ø)
...ners/TransactionListener/TransactionListener.swift 61.11% <100.00%> (ø)
.../Models/Internal/Protocols/IStoreTransaction.swift 0.00% <ø> (ø)
...lare/Classes/Models/Internal/SK1StorePayment.swift 100.00% <100.00%> (ø)
...lare/Classes/Models/Internal/SK1StoreProduct.swift 80.00% <100.00%> (ø)
...lare/Classes/Models/Internal/SK2StoreProduct.swift 78.57% <100.00%> (+2.38%) ⬆️
...ources/Flare/Classes/Models/StoreTransaction.swift 42.86% <ø> (ø)
... and 38 more

... and 20 files with indirect coverage changes

@ns-vasilev ns-vasilev added the flare-core Related to Flare component label Dec 26, 2024
@ns-vasilev ns-vasilev merged commit dcca329 into dev Dec 27, 2024
58 checks passed
@ns-vasilev ns-vasilev deleted the feature/swift6 branch December 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flare-core Related to Flare component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants