Add variable to specify desired AMI architecture #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeohist
force-pushed
the
ami_architecture_variable
branch
from
ddde9f3 to
046db0d
Compare
peterdeme
reviewed
Apr 7, 2025
jeohist
force-pushed
the
ami_architecture_variable
branch
3 times, most recently
from
3335e7d to
10e8233
Compare
peterdeme
previously approved these changes
Apr 14, 2025
|
hey, there seems to be an issue. did you have the chance to test it yourself? 
|
jeohist
force-pushed
the
ami_architecture_variable
branch
from
10e8233 to
80e7900
Compare
|
@peterdeme Yeah, mixed up the logic. I've updated it to be the same on both sides. |
* Add `var.ami_architecture` to allow users to specify their desired AMI architecture. * Make `data.aws_ami.this` conditional on whether `var.ami_id` is specified. If it is specified, it's not necessary to lookup the AMI ID. * Updated the example / test case to test with the `var.ami_architecture` variable. Resolves <spacelift-io#139>
jeohist
force-pushed
the
ami_architecture_variable
branch
from
80e7900 to
50e6a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
var.ami_architectureto allow users to specify their desired AMI architecture.data.aws_ami.thisconditional on whethervar.ami_idis specified. If it is specified, it's not necessary to lookup the AMI ID.var.ami_architecturevariable.Resolves #139
Type of change
Checklists
Development
Code review