-
Notifications
You must be signed in to change notification settings - Fork 19
Update docs 003a #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KiraLempereur-Spacelift
wants to merge
26
commits into
main
Choose a base branch
from
update-docs-003a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update docs 003a #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed indentation formatting for login policies member and teams sections. Added info on US regional URLs needed for worker pools AWS services. Changed some admonition types.
See https://www.notion.so/spacelift/Branch-update-docs-002-22a251e5616a806f8444d68b519e0f5e for a full list of items that have been added or changed. Some screenshots have also been updated and added.
Updated alt text and SS file for launchpad step 4 (hoping to resolve failed check on PR 847
There's no reason this should be failing, the link to the image is completely valid. Did oxipng ruin something? Anyways, manually retyped link and we'll see how things go now.
There, pre-commit markdown link check, are you happy now? Deleted the image link (../../assets/screenshots/getting-started/invite-teammates/Launchpad-step-4-done.png) that was apparently causing 400 error when markdown link check ran on the repo. We'll see if the one on line 78 causes the same error.
the link check will apparently only show me one dead link at a time so hold your horses, let's knock these out.
Added https://azure.microsoft.com/en-us/products/kubernetes-service to ignored patterns in markdown-link-check.json
Removed 7 unused assets (images) from repo
Fixed typos and weird formatting on some pages (nested lists) Added fresh AWS ARN screenshot
Per request, added a link to custom workflow tool in the OpenTofu/Terraform section
…r-documentation into update-docs-002
See PR convo for a list of items that were updated
just moved back one level
It was failing with code 403 but I could access the URL just fine myself, so other users should be able to.
Updated several Stacks documentation pages. Updated creating-a-stack to the info from getting started section and combined with deleting and locking stacks. Beginning to update cloud provider details to simply link to setup info in getting started section.
We just need to update the files that have been altered since update-docs-002 was merged to main. I'll take a look at resolving conflicts next week. |
Made links a little more relative so hopefully the pre-commit link check doesn't struggle
…er-documentation into update-docs-003a
Some updates to the stack settings and stack dependencies pages
Changed the links to the ones in the getting started section so hopefully pre-commit doesn't think they're dead
Fixed ALL relative links on the page
Updated dead link to proper one in concepts/run/task.md. Added aur.archlinux.org URLs to markdown link check ignores, because the links are live.
Added https://api.github.com/ to ignore
Removed lots of unused and/or outdated screenshots for stack creations, AWS cloud providers, etc. Fixed reference to one SS in GitHub source control getting started page.
Resolve comments from Jubran's review, note that all scheduling requires private workers, fix capslock CRON, etc. Also copied the new stack nav to self-hosted nav.yaml file
jubranNassar
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Starting on updates to the Stacks documentation and refining the cloud integration and source code integration docs to reflect info from the new getting started pages.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
main
branch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering
. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇