Maintenance (2025 may) #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated from v2 to v3 of the urfave/cli library, following the migration guide:
- Updated import path from github.com/urfave/cli/v2 to github.com/urfave/cli/v3
- Changed EnvVars: []string{} to Sources: cli.EnvVars() for all flags
- Changed cli.App to cli.Command
- Updated Action function signature to include context
- Updated app.Run in main() to use the new signature with context
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
peterdeme
force-pushed
the
maintenance-2025-may
branch
from
bee4ee4 to
a2082f1
Compare
peterdeme
force-pushed
the
maintenance-2025-may
branch
from
a2082f1 to
d38b606
Compare
- Replaced the goblin test framework with standard Go testing - Used subtests (t.Run()) for better test organization - Used testify/assert and testify/require for assertions - Removed unused dependencies (franela/goblin, onsi/gomega) - Fixed linting issues in http_client.go 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: peterdeme <[email protected]>
peterdeme
force-pushed
the
maintenance-2025-may
branch
from
d38b606 to
b9afeec
Compare
peterdeme
commented
May 12, 2025
| RUN apk add --no-cache ca-certificates && apk upgrade --update-cache --available | ||
| RUN apk upgrade --update-cache --available && apk add ca-certificates && rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
noticed that the add --no-cache didn't make sense as the next statement added a cache anyway 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Checklists
Development
Code review
Deployment