Skip to content

chore: write_node doesn't need mut reference #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: write_node doesn't need mut reference #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12fb800
flush if over sized
zhiqiangxu Apr 8, 2024
1f8d5a0
reduce scope of config
zhiqiangxu Apr 8, 2024
219b9a5
Node doesn't have to be mut
zhiqiangxu Apr 8, 2024
4dffa6f
remove impossible path
zhiqiangxu Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,13 +377,11 @@ impl<'file, const SIZE: usize> WriteBuffer<'file, SIZE> {
Ok(record)
}

pub fn write_node(&mut self, node: &mut Node) -> Result<Record, io::Error> {
pub fn write_node(&mut self, node: &Node) -> Result<Record, io::Error> {
if self.remaining() < node.mem_size() {
self.flush()?;
}

let config = config::standard();

if node.inner.is_none() {
if node.id != EMPTY_RECORD {
return Ok(node.id);
Expand All @@ -392,7 +390,8 @@ impl<'file, const SIZE: usize> WriteBuffer<'file, SIZE> {
}

let size = {
let inner = node.inner.as_mut().unwrap();
let inner = node.inner.as_ref().unwrap();
let config = config::standard();
bincode::encode_into_slice(inner, &mut self.tail(), config).map_err(|e| {
io::Error::new(
io::ErrorKind::Other,
Expand Down