-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix specviz2d model fit linking #3434
Open
pllim
wants to merge
3
commits into
spacetelescope:main
Choose a base branch
from
pllim:fix-specviz2d-model-fit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this patch
pllim
commented
Feb 11, 2025
assert len(specviz2d_helper.app.data_collection) == 3 # model is created | ||
|
||
elink = specviz2d_helper.app.data_collection.external_links[-1] | ||
assert elink.data1.label == "Spectrum 1D" and elink.data2.label == "model", (elink.data1.label, elink.data2.label) # noqa: E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this patch, this test would fail on main
as such:
> assert elink.data1.label == "Spectrum 1D" and elink.data2.label == "model", (elink.data1.label, elink.data2.label) # noqa: E501
E AssertionError: ('Spectrum 2D', 'model')
E assert ('Spectrum 2D' == 'Spectrum 1D'
E
E - Spectrum 1D
E ? ^
E + Spectrum 2D
E ? ^)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3434 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 128 128
Lines 19962 19962
=======================================
Hits 17474 17474
Misses 2488 2488 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v4.1.x
on-merge: backport to v4.1.x
bug
Something isn't working
plugin
Label for plugins common to multiple configurations
specviz2d
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to fix modeling fitting linking in Specviz2D so that fitted model does not appear weird over
x=0
and would instead plot properly on 1D spectrum viewer. We do not support 2D model fit, so it will never have to display in 2D spectrum viewer.With this patch:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.