Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook showing how to rescale photometry values from ERR extension #24

Conversation

bhilbert4
Copy link
Collaborator

Add a notebook showing necessary rescaling of photometric uncertainty values when derived from the ERR extension of i2d files in cases where the data have been resampled to a non-native detector pixel scale. This was first reported to the Help Desk in incident INC0202025, and discussed in detail in JP-3680.

Anton has looked over the notebook, and says it looks good.

@bhilbert4 bhilbert4 requested a review from sosey as a code owner October 7, 2024 15:09
Copy link
Member

@sosey sosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're notebook references a requirements.txt file but doesn't include it in this PR. When I create a default env, I still needed to install astroquery after creating a default env with jwst. Check what's in your requirements file and add it to the pr :)

otherwise looked good.

@bhilbert4
Copy link
Collaborator Author

All set. requirements file is in place, and I tested the notebook with the env it creates.

Copy link
Member

@sosey sosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding!

@sosey sosey merged commit ebf8ba8 into spacetelescope:main Nov 27, 2024
1 check passed
@bhilbert4 bhilbert4 deleted the scale-ERR-for-nonnative-pixscale-resampling branch November 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants