-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing errors in CI #94
base: main
Are you sure you want to change the base?
Conversation
Tagging @adrianlucy @scfleming for visibility |
Thanks Sam! Will review ~Thursday-ish, but one quick minor thing that caught my eye: diff changes from In theory if the unwanted output in this PR takes up significant storage, I guess you might want to consider squashing the commits that take up space in the history?, but up to you / judgement call whether that's worth your time. |
That is weird, apparently the "Clear All Outputs" button in VSCode doesn't actually reset the execution count! The notebooks shouldn't actually have any output. I'll see if I can find a way to reset that variable. |
Oh interesting, weird! At least we don't have to worry about the commit history then. FWIW in Jupyter itself I think it's "restart kernel and clear outputs"(?) but I can see it being a hassle to switch between VScode's implementation and Jupyter. |
Updating the notebooks that are failing in our nightly CI build.