Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect bundled qd #267

Merged
merged 2 commits into from
May 9, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 6, 2024

@pllim pllim requested a review from jhunkeler May 6, 2024 18:37
@pllim pllim requested a review from a team as a code owner May 6, 2024 18:37
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (5de7fc7) to head (c2d4ed4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files           5        5           
  Lines        1010     1010           
=======================================
  Hits          821      821           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhunkeler
Copy link
Contributor

setup.py build is legacy command.

Shouldn't this be replaced with USE_SYSTEM_QD=1 pip install .? USE_SYSTEM_QD is an environment variable.

@pllim
Copy link
Contributor Author

pllim commented May 6, 2024

I thought life would be more exciting if they have to search how to install themselves, but ok.

@mcara mcara merged commit 7e78fb4 into spacetelescope:master May 9, 2024
15 of 16 checks passed
@pllim pllim deleted the update-qd-readme branch May 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants