apfelxx, epic, partons*, sfml: new packages#4717
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds several new Spack package recipes to support a small HEP Monte Carlo / PDF tooling stack (EpIC + PARTONS and their supporting libraries), including an sfml dependency.
Changes:
- Added new package recipes:
apfelxx,epic,partons,partons-numa,partons-elementary-utils, andsfml. - Declared dependency relationships between EpIC/PARTONS and the supporting libraries.
- Added basic CMake configuration via variants for
sfml.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| repos/spack_repo/builtin/packages/sfml/package.py | New sfml CMake package with module variants and CMake configure flags. |
| repos/spack_repo/builtin/packages/partons/package.py | New partons CMake package with declared HEP/math dependencies. |
| repos/spack_repo/builtin/packages/partons_numa/package.py | New partons-numa CMake package and dependencies. |
| repos/spack_repo/builtin/packages/partons_elementary_utils/package.py | New partons-elementary-utils CMake package and dependencies. |
| repos/spack_repo/builtin/packages/epic/package.py | New epic CMake package with dependencies and custom install step. |
| repos/spack_repo/builtin/packages/apfelxx/package.py | New apfelxx CMake package with LHAPDF/yaml-cpp/pybind11 dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sethrj
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a stack of parton distribution function Monte Carlo packages (and multimedia package that they depend on for the only reason that it provides a Mutex class...).
Test builds (since
epicandpartonsdepends on the others, I hope this is sufficient; the rest is buried in a large environment):and
(I have a different local package that has the name
epic, so I had to mapbuiltin.epicontoepic-generator.)