-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working template get_function_url with test #1004
Open
dave42w
wants to merge
37
commits into
sparckles:main
Choose a base branch
from
dave42w:url_for
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−4
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
14461b2
Initial static text url_for implementation
dave42w 6b907b2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 68d4f2e
Working url_for
dave42w d0d8e7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 560dcd2
Merge branch 'sparckles:main' into url_for
dave42w 2a02a6a
Sort linter errors
dave42w 8433c59
sync project.toml and poetry.lock
dave42w 25df6bc
Corrected import for Route
dave42w 39dac34
Needed to run using uv
dave42w c54238a
Needed to use integration tests with uv
dave42w 11f198a
remove temporary pytest mark
dave42w beae5ee
update pytest to avoid lots of python 3.14 depreciation warnings
dave42w 032c247
Added abstract methodist to interface, added a docstring for set_roby…
dave42w e9df6ab
rename url_for to get_function_url & working HttpMethod arg & unit te…
dave42w 620fb62
encoding wasn't needed (causing me git problems with the utf-8 specified
dave42w a24d8e2
Move as much uv stuff as possible into separate sections
dave42w bfb3ca8
Moving pyproject.toml target
dave42w 6a5168c
Merge branch 'sparckles:main' into url_for
dave42w 79318e9
support for kwargs for url's with tests
dave42w 32836ff
support for kwargs for url's with tests
dave42w b655eba
support for kwargs for url's with tests
dave42w 3d93d85
restore pyproject
dave42w c87a201
Merge branch 'sparckles:main' into url_for
dave42w 3829ab3
Merge branch 'sparckles:main' into url_for
dave42w f489ee2
Merge branch 'sparckles:main' into url_for
dave42w f6193ea
Fix linter complaints
dave42w 67c535b
Merge branch 'sparckles:main' into url_for
dave42w e151981
Merge branch 'sparckles:main' into url_for
dave42w 1bc1fb7
Merge branch 'sparckles:main' into url_for
dave42w 32e98d5
Merge branch 'sparckles:main' into url_for
dave42w 1885a67
Merge branch 'sparckles:main' into url_for
dave42w 14e57c5
fix: Use Union for python 3.8 compatibility instead of |
dave42w 842c610
Merge branch 'sparckles:main' into url_for
dave42w f3e5e24
Merge branch 'sparckles:main' into url_for
dave42w 43b3efc
Merge branch 'sparckles:main' into url_for
dave42w 2ce9b02
Merge branch 'sparckles:main' into url_for
dave42w a68fea8
Merge branch 'sparckles:main' into url_for
dave42w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
commit d0d8e7b8c56317b06781f772665040c5c3abae92
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dave42w 👋
Thanks for the PR again. But I am not super satisfied with the implementation here. Honestly, I am not certain what I am expecting here. Is there a way to not have
set_robyn
function ?