Feat before request #1125
Open
Feat before request #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
sansyrox
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Hey @tengfeisky 👋
Thanks for the PR :D I have some comments. Could you have a look?
|
|
||
| @app.get("/sync/global/middlewares/with_request") | ||
| def sync_global_middlewares_with_request(request: Request): | ||
| print(request.headers) |
|
|
||
| @app.get("/async/global/middlewares/with_request") | ||
| def sync_global_middlewares_with_request(request: Request): | ||
| print(request.headers) |
Comment on lines
+44
to
+48
| if let Ok(tuple) = function_args.downcast::<PyTuple>(py) { | ||
| handler.call(tuple, Some(kwargs)) | ||
| } else { | ||
| handler.call((function_args,), Some(kwargs)) | ||
| } |
There was a problem hiding this comment.
can you please explain this line of code to me?
There was a problem hiding this comment.
In Rust, this syntax (function_args,) creates a nested tuple in Python, similar to ((arg1,arg2),).
sansyrox
reviewed
Feb 24, 2025
| @@ -1,5 +1,6 @@ | |||
| use crate::executors::{ | |||
| execute_http_function, execute_middleware_function, execute_startup_handler, | |||
| execute_http_function, execute_middleware_after_request, execute_middleware_function, | |||
There was a problem hiding this comment.
I think we can do slightly better here.
i.e. execute_middleware_after_request and execute_middleware_function are not correct nomenclature imo.
There was a problem hiding this comment.
What is your suggestion then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds request parameter to after_request middleware
Summary
This PR adds the request parameter to the after_request middleware function to enable proper propagation of trace_id between request and response headers. This change supports distributed tracing functionality by ensuring that the trace_id remains consistent throughout the request lifecycle and can be properly passed to downstream services.
PR Checklist
Please ensure that:
Pre-Commit Instructions: