Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1138 - Add support for generic types such as List[Object] #1139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yzutyc
Copy link

@yzutyc yzutyc commented Mar 6, 2025

Description

This PR fixes #

Summary

This PR does....

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 1:25am

@sansyrox sansyrox changed the title fix bug( issue:1138 ) 添加对泛型类型(如List[Object])的支持 fix #1138 - Add support for generic types such as List[Object] Mar 6, 2025
robyn/openapi.py Outdated
Comment on lines 397 to 401
# 检查是否为泛型类型(如List[Object])
if hasattr(param_type, "__origin__"):
if param_type.__origin__ is list or param_type.__origin__ is List:
properties["type"] = "array"
# 处理列表中的元素类型
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yzutyc 👋

Would it be possible for you to change your comments to English?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants