feat: add header component #11
Conversation
|
📦 Extension packages built successfully! |
marissahuysentruyt
left a comment
marissahuysentruyt
left a comment
There was a problem hiding this comment.
I think there's just the one variable that we should be able to safely remove, and this is good to go. 👍
| gap: 1rem; | ||
| align-items: center; | ||
| padding: 1rem 1.5rem; | ||
| /* TODO: The `border-bottom` color is equal to `--cv-color-gray-50` and should be replaced with the variable when implemented */ |
There was a problem hiding this comment.
I can create a ticket for this if needed. I think we could add :root to the selector for all of the color variables, or maybe we could to add the .cv class to the topmost .cv-panel div (I think?).
There was a problem hiding this comment.
Yeah, that would be great! I'm not seeing an existing ticket for implementing our .cv styles, but we could include moving and renaming --cv-black and --cv-white in that work too.
There was a problem hiding this comment.
Good idea- I will create that today 😊
src/styles/core.css
Outdated
| /* neutrals */ | ||
| --cv-black: hsl(0deg 0% 0%); | ||
| --cv-white: hsl(0deg 0% 100%); | ||
| --cv-grey: hsl(0deg 0% 50%); |
There was a problem hiding this comment.
This doesn't look like it's being used in this file. Can we delete it, or am I missing it somewhere else?
arnest00
force-pushed
the
feat--branding-header-component
branch
from
d6d330e to
887c457
Compare
This work adds a header component that is inserted on the welcome and results panels during initialization.
Relevant links
To validate
feat--branding-header-componentnpm iandnpm run build