feat: isolate styles from page contents #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Extension packages built successfully! |
dustin-jw
force-pushed
the
feat--isolate-styles
branch
2 times, most recently
from
1c26e8e to
6199d59
Compare
dustin-jw
force-pushed
the
feat--isolate-styles
branch
from
6199d59 to
8343167
Compare
dustin-jw
force-pushed
the
feat--isolate-styles
branch
from
8343167 to
2d51894
Compare
dustin-jw
force-pushed
the
feat--isolate-styles
branch
from
917993b to
3af05bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is meant to prevent page styles from interfering with the panel's styles by reverting all properties within the panel, then setting whatever styles we need. Sites that change the root font size will cause trouble, such as this one, but there's not much we can do to mitigate that (it's bad practice anyway). There may be cases where the specificity of a page's styling for a particular element is higher than the selector that reverts the page styles, but those seem to be rare as far as I can tell.
To Validate
npm run build