check if SUBundleName is set before normalizing #1444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1442
When changing the name of an app, there's a couple things to do in order
to ensure auto-updates still work:
of {SUBundleName}.(app|pkg) instead of the normal name."
SPARKLE_NORMALIZE_INSTALLED_APPLICATION_NAME
incommonConfig.xccconfig to reset the name of the app.
in (2), we always used the host's bundle name, instead of checking to
see if SUBundleName was set, which means normalization doesn't work as
expected during app name changes.
A problem that arises is that we will ALWAYS normalize the installed
.app
path toSUBundleName
--even if the thing you're updating to has a different bundle name fromSUBundleName
.I think that's expected behavior, if you specify
SUBundleName
andNormalize
, but it does seem odd.Testing I've done
made
Some App Name.app
update toDifferent App Name.app
SUBundleName
toDifferent App Name
SPARKLE_NORMALIZE_INSTALLED_APPLICATION_NAME = 1
Some App Name.app
becomeDifferent App Name.app
when installing the updatemade
Some App Name.app
update to a later build ofSome App Name.app
SUBundleName
toDifferent App Name
SPARKLE_NORMALIZE_INSTALLED_APPLICATION_NAME = 1
Some App Name.app
becomeDifferent App Name.app
when installing the update, even though it's really installingSome App Name
Other To-Dos?
SPARKLE_NORMALIZE_INSTALLED_APPLICATION_NAME
should be mentioned a bit more prominently--I had to do some digging to find out it was an option for the behavior I want