Repository navigation
refactor: source the API origin from @canup/contracts (single constant) - #29
Merged
Merged
Conversation
Both packages defined their own DEFAULT_API_URL ('https://canup.link').
Import the canonical DEFAULT_CANUP_URL (and API_VERSION) from
@canup/contracts instead and delete the local copies (cli/constants.ts and
the inline ui const) — one definition, no drift. Bumps the contract
dependency to 0.2.1, which adds the constants.
Coverage Report for @canup/ui (packages/ui)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Coverage Report for @canup/cli (packages/cli)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default API origin (
https://canup.link) was defined in three places under two names —DEFAULT_API_URLincli/constants.ts, an inlineDEFAULT_API_URLinui/internal/api-client.ts, andDEFAULT_CANUP_URLin@canup/contracts. This collapses them to one definition.import { DEFAULT_CANUP_URL } from '@canup/contracts'and use it directly; the CLI also takesAPI_VERSIONfrom there.cli/constants.tsis deleted (both its exports now live in the contract); the inline ui const is gone.@canup/contractsto^0.2.1, the release that adds the constants.One canonical origin, no drift between client and contract. Net −5 lines.
Verification
test(358 cli + 115 ui),lint,typecheck,build— all green. NoDEFAULT_API_URLor hardcoded origin remains in source.