Repository navigation
fix: declare tsx as a runtime dependency of the CLI - #30
Merged
Merged
Conversation
`canup actions test` runs a local Node.js action by resolving the tsx
binary (require.resolve('tsx/cli')) and spawning it. tsx was a dependency
of the pre-split package but was dropped when the CLI moved to its own
package, so the resolve throws "Cannot find module 'tsx/cli'" and local
Node action testing fails for every user. Re-declare it (^4.19.4, the
pre-split version).
Coverage Report for @canup/ui (packages/ui)
File CoverageNo changed files found. |
Coverage Report for @canup/cli (packages/cli)
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canup actions testruns a local Node.js action by resolving the tsx binary (require.resolve('tsx/cli')) and spawning it.tsxwas a dependency of the pre-split package but was dropped when the CLI moved into its own package — so the resolve throwsCannot find module 'tsx/cli'and local Node action testing is broken for every user, not just in tests.Re-declares
tsx@^4.19.4(the pre-split version) as a runtime dependency of@canup/cli.Verified:
require.resolve('tsx/cli')now resolves from the CLI's location; the e2etest Node.js action locallypasses. test/lint/typecheck/build green.