Repository navigation
feat(ui): align credit & subscription status with Canva's monetization pattern - #31
Merged
Merged
Conversation
…n pattern
ActionCredits folds the refresh cadence into the credit noun ("7 of 10 App monthly credits left"), and omits the cadence word when credits don't refresh. ActionCredits and SubscriptionStatus now follow Canva's monetization-status pattern: small text, the count in a bold span, and the status line tight against its CTA (0u) with account details 1u below.
Credit-status translations are updated across all supported locales.
…nt API The README still referenced the removed CreditCounter component, the pre-split `canup` import, and the old error `type` field. Update it to import from `@canup/ui`, use SubscriptionStatus, and read `error.code`.
Coverage Report for @canup/ui (packages/ui)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report for @canup/cli (packages/cli)
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the monetization-status components in line with Canva's documented Monetization Status pattern and improves the credit copy.
Changes
ActionCreditsfolds the refresh cadence into the credit noun ("7 of 10 App monthly credits left"), and omits the cadence word entirely when credits don't refresh (lifetime / no interval). Translations updated across all supported locales.ActionCreditsandSubscriptionStatusnow follow the pattern:size="small"status text, the count in a bold span, and the status line tight against its CTA (Rows spacing="0") with account-details lines1ubelow.CreditCounter, the pre-splitcanupimport, and the old errortypefield; updated to@canup/ui+SubscriptionStatus+error.code.Verification
test,lint,typecheck,buildall green locally.