Organize config + management command dirs#701
Merged
Conversation
Rename directories to avoid confusing names like `src/src` and make management command consistent with actual implementation file (`cleanup_media` -> `cleanup_media.py`). Follow-up of test suite reorganization. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
rtgdk
approved these changes
Jul 14, 2026
rtgdk
left a comment
rtgdk
left a comment
Collaborator
There was a problem hiding this comment.
Review summary
Clean, thorough rename. All 26 files are consistently updated — no remaining from src.* imports, no leftover app.scripts.cleanup references, supervisor_api.conf and manage.py are both correct, and the utils package is properly initialized with __init__.py. README-PRODUCTION.md and the Dockerfile are unaffected (no Dockerfile exists). One cosmetic nit in wsgi.py; nothing blocking.
Verdict: Approved. Ready to merge.
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/src/tosrc/config/, make it less confusing and has more meaningful name; updating related code, tests, workflow, and documentation.src/app/utils.pyinto a package and moved the media cleanup script fromapp/scripts/cleanup.pytoapp/utils/cleanup_media.py(matching the command name); renametest_cron.pytotest_cleanup_media.py.Follow-up of test suite reorganization.