-
Notifications
You must be signed in to change notification settings - Fork 17
feat: allow customization of "View Docs" in the MCP server install page #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DhashS
wants to merge
15
commits into
main
Choose a base branch
from
ds/feature/customize-additional-header-button-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,307
−2,230
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e9292bc
html template + add struct member for button text
DhashS 3bd1c0e
add additional field + migration to db for btn txt
DhashS 484445c
rename this field due to quinn's feedback
DhashS aeff4ec
add new field to design
DhashS d2655e6
update seed script
DhashS 8d138ac
push the docsbtntext from db into templating
DhashS dba3aff
chore: gen server
tgmendes 79c53cd
chore: gen sdk
tgmendes 7176f21
merging
DhashS 141745a
don't forget to rename the struct field
DhashS 85b616c
Merge branch 'main' into ds/feature/customize-additional-header-butto…
DhashS cb2b132
step 1: evolve the schema
DhashS d2a02cf
step 2: run migration
DhashS 5f4f1fd
uh try this?
DhashS 387ef8a
erge branch 'ds/feature/add-db-migration-for-documentation-text' int…
DhashS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 2 additions & 0 deletions
2
server/migrations/20260129185604_add-mcp-metadata-title-slug.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| -- Modify "mcp_metadata" table | ||
| ALTER TABLE "mcp_metadata" ADD COLUMN "external_documentation_text" text NULL; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 SetMcpMetadata doesn't handle ExternalDocumentationText payload field
The
SetMcpMetadatafunction doesn't process thepayload.ExternalDocumentationTextfield and doesn't pass it to theUpsertMetadataParams.Click to expand
Impact
The API design at
server/design/mcpmetadata/design.go:178defines the payload attribute:But
SetMcpMetadatainimpl.goonly handles these fields from the payload:ExternalDocumentationURL(line 211-214)Instructions(line 216-219)LogoAssetID,DefaultEnvironmentID,InstallationOverrideURL, etc.The
ExternalDocumentationTextfield is never read from the payload and never passed toUpsertMetadataParamsat lines 235-243.Expected behavior
The function should extract
payload.ExternalDocumentationTextand include it in theUpsertMetadataParamsstruct passed tos.repo.UpsertMetadata().(Refers to lines 235-243)
Was this helpful? React with 👍 or 👎 to provide feedback.