docs: show correct add_url_rule example for AsyncApp - #2131
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
The individual-paths example returned a bare status code and took no request argument, which only works for FlaskApp. AsyncApp routes through Starlette, so its view function receives a Request and returns a Response. Split the example per framework so both are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The individual-paths example in the routing docs returned a bare status code and took no request argument, which only works for FlaskApp. AsyncApp routes through Starlette, so its view function receives a Request and returns a Response. This splits the example per framework so both are correct.
Closes #1946