don't generate unused functions in bindings #138
Conversation
| once: ( | ||
| cb: TAURI_API_EVENT.EventCallback<T>, | ||
| ) => ReturnType<typeof TAURI_API_EVENT.once<T>>; | ||
| emit: T extends null |
There was a problem hiding this comment.
Can you explain this change?
It also differs from the JS Doc alternative so they will need to match for this to be merged.
There was a problem hiding this comment.
to be honest i don't know when/how this changed. i will undo the change.
There was a problem hiding this comment.
For some reason when running tests, it creates this change. Thought I'd broken something somewhere but it just happens when you run tests lol
There was a problem hiding this comment.
Okay cool. As long as the JS doc part also matches we can resolve this.
I commented and made a small change. Is there anything else that is still wrong? |
|
|
||
| import { | ||
| invoke as TAURI_INVOKE, | ||
| Channel as TAURI_CHANNEL, |
There was a problem hiding this comment.
I think this is reqiured when using channels for them to work. They must be called Channel as we basically rely on shadowing to make it work.
| once: ( | ||
| cb: TAURI_API_EVENT.EventCallback<T>, | ||
| ) => ReturnType<typeof TAURI_API_EVENT.once<T>>; | ||
| emit: T extends null |
There was a problem hiding this comment.
Okay cool. As long as the JS doc part also matches we can resolve this.
When there are no events, part of the bindings file is unused.
In my case with
"noUnusedLocals": true,in the tsconfig this lead to my project not compiling.This PR splits the global.ts and global.js into two parts and only includes the event related code if there are any events defined.
I tested this in my project, but I am not very used to ts/js. So feel free to point out any issues.