PCP-6608: cluster-api-provider-maas wipes API server FQDN empty IP set persisted to MAAS DNS when CP machine is transiently powered off, hash-cached so no self-recovery#340
Merged
Conversation
…et persisted to MAAS DNS when CP machine is transiently powered off, hash-cached so no self-recovery
- Remove empty-IP guard from updateResourceIPs helper; guard belongs in reconcileDNSAttachments where intent is known, not in a shared helper that must support intentional clearing (deprovisioning) - Deduplicate runningIpAddresses before hashing so the annotation always represents the applied IP set, consistent with updateResourceIPs set semantics — prevents spurious re-syncs if duplicate IPs appear - Add IsDriftDetected edge-case tests: duplicate desired IPs and empty strings in desired are correctly handled without false drift signals
Fix #2 - last CP deletion leaves stale DNS: Track existingCPCount (CPs without DeletionTimestamp) separately. Preserve DNS only when existingCPCount > 0 (transient power-off flap). When existingCPCount == 0 (all CPs absent or pending deletion), fall through to clear DNS so stale records don't persist after a rolling replacement or scale-down. Tests (#4, #5, #6): - CP with DeletionTimestamp: excluded from existingCPCount, DNS cleared - CP running but no ExternalIP: existingCPCount>0, DNS preserved (covers preferred-subnet mismatch code path) - GetDNSResource error: error propagated to caller - Updated "no CP machines" assertion to reflect new DNS-clear behaviour
AmitSahastra
changed the title
vishu2498
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.