PCP-6716: Cherry pick storage and subnet fix#341
Merged
Conversation
…nk_subnet (#318) * Fix wrong subnet in use existing VM flow * feat: add AUTO link mode and LinkSubnetWithMode for MAAS link_subnet * fix unit tests * change to use new maas client go * fix pkg/maas/lxd/host_maas_client_test.go * add unit test for resolveLinkMode --------- Co-authored-by: kun zhou <kun.zhou@spectrocloud.com> Co-authored-by: Kun Zhou <156021375+Kun483@users.noreply.github.com>
…t prevention fix (#338)
…s in host selection (#325)
![bulwark-spectrocloud[bot]](https://avatars.githubusercontent.com/u/36211249?s=60&v=4){kind=small}
There was a problem hiding this comment.
- GO-2026-4918
- Module: golang.org/x/net
- Found in: v0.38.0
- Fixed in: v0.53.0
- Example Traces:
1. pkg/maas/dns/dns.go:52:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http2.run
2. pkg/maas/dns/dns.go:52:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip
3. pkg/maas/dns/dns.go:52:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip
4. pkg/maas/dns/dns.go:52:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip
Please review these findings and fix the issues before merging.
bulwark-spectrocloud
Bot
dismissed
their stale review
Changes have been made to address the security findings.
tiwarisumit3
changed the title
AmitSahastra
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.