Skip to content

PCP-6876: Fix: proxy image and cherry pick hypershift commits#349

Merged
AmitSahastra merged 5 commits into
mainfrom
fix/proxy-hypershift
Jun 9, 2026
Merged

PCP-6876: Fix: proxy image and cherry pick hypershift commits#349
AmitSahastra merged 5 commits into
mainfrom
fix/proxy-hypershift

Conversation

@Kun483

@Kun483 Kun483 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator
  • Fix kube-rbac-proxy image
  • cherry pick hyper shift commits
  • fix govuln

guyni and others added 3 commits June 4, 2026 11:10
* Added InternalIP to Machine's status.addresses

* Added InternalDNS to Machine's status.addresses

* support hypershift nodes with FQDN

---------

Co-authored-by: jzhoucliqr <zhoujun06@gmail.com>
@Kun483 Kun483 requested review from AmitSahastra and snehala27 June 4, 2026 19:10

@bulwark-spectrocloud bulwark-spectrocloud Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ GoVulnCheck scan found vulnerabilities:

  1. GO-2026-5026
    • Module: golang.org/x/net
    • Found in: v0.33.0
    • Fixed in: v0.55.0
    • Example Traces:
      1. pkg/maas/dns/dns.go:45:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http2.authorityAddr
  2. GO-2026-4918
    • Module: golang.org/x/net
    • Found in: v0.33.0
    • Fixed in: v0.53.0
    • Example Traces:
      1. pkg/maas/dns/dns.go:45:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http2.run
      2. pkg/maas/dns/dns.go:45:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip
      3. pkg/maas/dns/dns.go:45:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip
      4. pkg/maas/dns/dns.go:45:10: dns.ReconcileDNS calls maasclient.Create, which eventually calls http.roundTrip

Please review these findings and fix the issues before merging.

@bulwark-spectrocloud bulwark-spectrocloud Bot dismissed their stale review June 4, 2026 19:13

Changes have been made to address the security findings.

@AmitSahastra AmitSahastra merged commit 06e8ae1 into main Jun 9, 2026
4 checks passed
@AmitSahastra AmitSahastra deleted the fix/proxy-hypershift branch June 9, 2026 02:56
@Kun483 Kun483 changed the title Fix: proxy image and cherry pick hypershift commits PCP-6876: Fix: proxy image and cherry pick hypershift commits Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants