Skip to content

fix: implement audit reviews #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2025
Merged

fix: implement audit reviews #36

merged 7 commits into from
May 30, 2025

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 28, 2025 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Router.sol 45.45% 6 Missing ⚠️
src/Intent.sol 0.00% 2 Missing ⚠️
src/swapModules/SwapAlgebra.sol 81.81% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lumtis lumtis marked this pull request as ready for review May 29, 2025 11:03
@lumtis lumtis requested a review from s2imonovic May 29, 2025 11:05
s2imonovic
s2imonovic approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@s2imonovic s2imonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

maybe I would use forceApprove() from SafeERC20 instead of doing 0 approval and then real approval.

also, consider separating different logical units in swap() from the SwapAlgebra module into smaller internal functions

@lumtis lumtis merged commit 9da7ddc into main May 30, 2025
1 of 2 checks passed
@lumtis lumtis deleted the audit-checkup branch July 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s2imonovic s2imonovic s2imonovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumtis @s2imonovic