clarify relayfee method and add blockchain.mempoolminfee method #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of
blockchain.relayfee()
promises the user thattransactions paying the relayfee will get accepted into the servers
mempool. This however seems incorrect as the relayfee is just a
fixed value in the core backend (either configured or a hardcoded default value)
and doesn't change with a growing mempool.
See definition:
https://github.com/bitcoin/bitcoin/blob/d387b8ec15e553db9b9c370314ee359e981fb374/src/main.cpp#L55-L56
and usage for the API:
https://github.com/bitcoin/bitcoin/blob/d387b8ec15e553db9b9c370314ee359e981fb374/src/rpcmisc.cpp#L86-L87
To get the minimal feerate to be paid for mempool acceptance one has to
use getmempoolinfo['mempoolminfee'] being added here as
blockchain.mempoolminfee()
This can be useful for things like lightning anchor commitment tx fees as discussed here:
spesmilo/electrum#9826