Skip to content

chore: build with Go 1.26.10 - #88

Merged
amartinezfayo merged 1 commit into
spiffe:mainfrom
keeganwitt:emudhra-toolchain-update
Oct 22, 2026
Merged

amartinezfayo merged 1 commit into
spiffe:mainfrom
keeganwitt:emudhra-toolchain-update

Conversation

@keeganwitt

@keeganwitt keeganwitt commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Use Go 1.26.10 for CI and code generation so the build toolchain includes the crypto/x509 distrust mitigation for CVE-2026-111943.

Update .go-version and the preferred toolchain, and make setup-go read .go-version instead of the library's language minimum. Preserve the existing Go 1.23 compatibility minimum.

This is precautionary build-environment maintenance. Generated plugin code does not inherit the generator's TLS verifier; consuming applications must use their own patched compiler and rebuild where their runtime trust paths are affected.

Validation on Windows with Go 1.26.10:

  • go test -p 2 -timeout 3m ./... passed.
  • go build -p 2 ./... passed.
  • go mod tidy -diff passed after normalizing local Windows line endings for the check; no checksum changes are included.
  • git diff --check passed.

Linux Make/protobuf regeneration remains for CI.

Follow-up: #89 restores the original go-version-file: go.mod CI convention and selects the patched compiler through the preferred toolchain in go.mod.

Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt
keeganwitt requested a review from a team as a code owner October 22, 2026 20:40
@amartinezfayo
amartinezfayo merged commit 5eb0bd2 into spiffe:main Oct 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants