Skip to content

Update PyPI links to point to this fork of the repo#3

Merged
joshuacwnewton merged 1 commit intoneuropoly-fork-patchesfrom
mgp/update-repo-links-2
Oct 24, 2025
Merged

Update PyPI links to point to this fork of the repo#3
joshuacwnewton merged 1 commit intoneuropoly-fork-patchesfrom
mgp/update-repo-links-2

Conversation

@mguaypaq
Copy link
Copy Markdown
Member

These links end up on https://pypi.org/project/nnunetv2-neuropoly/ when a new release is published.

(In contrast with #2, this PR is for the neuropoly-fork-patches branch.)

@joshuacwnewton
Copy link
Copy Markdown
Member

Good catch! Thanks much for this. :)

@joshuacwnewton
Copy link
Copy Markdown
Member

joshuacwnewton commented Oct 24, 2025

Since my tentative plan (in my head at least -- open to discussion!) is to repeatedly rebase this branch onto master to ensure compatibility + make replaying changes onto new release branches easier, I think I might fold these changes into commit 572b760, and treat that commit as the "neuropoly fork modifications to pyproject.toml" commit?

Before I do that, though, I might make an SCT wiki page on my thoughts on maintaining the fork (just to get feedback and make sure my ideas sound sensible).

For now we can just merge, though! :)

@joshuacwnewton joshuacwnewton merged commit 14c2c94 into neuropoly-fork-patches Oct 24, 2025
2 checks passed
@mguaypaq
Copy link
Copy Markdown
Member Author

Since my tentative plan (in my head at least -- open to discussion!) is to repeatedly rebase this branch onto master to ensure compatibility + make replaying changes onto new release branches easier, I think I might fold these changes into commit 572b760, and treat that commit as the "neuropoly fork modifications to pyproject.toml" commit?

I actually considered suggesting this myself! Mostly I didn't mention it because I figured it would be a post-PR-merge operation anyway, so maybe not relevant yet.

I think keeping the neuropoly-fork-patches branch as a short-ish sequence of easy-to-rebase, self-contained commits makes a lot of sense. But for your write-up, I'll suggest that for each release that gets uploaded to PyPI, we should keep a tag of the exact commit used for the upload as an immutable historical marker.

@mguaypaq mguaypaq deleted the mgp/update-repo-links-2 branch October 27, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants