Skip to content

Add opt-in to unstable wasip3 and warn when in use #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Add opt-in to unstable wasip3 and warn when in use #3322

merged 1 commit into from
Oct 27, 2025

Conversation

@fibonacci1729
Copy link
Collaborator

@fibonacci1729 fibonacci1729 commented Oct 23, 2025

Adds a new executor type for opting-in to wasip3 (a la wasip3-unstable).

Additionally a warning is added when running with the unstable feature enabled.

@fibonacci1729 fibonacci1729 linked an issue Oct 23, 2025 that may be closed by this pull request
Require more explicit opt-in to unstable wasip3 executor #3315
Closed
@lann
Copy link
Collaborator

lann commented Oct 23, 2025

I hope this causes a test failure. 🙂

itowlson
itowlson approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM but definitely needs other eyes on it!

@lann
Copy link
Collaborator

lann commented Oct 23, 2025

Hey my wish came true!

failures:
    integration_tests::test_wasi_http_p3_echo
    integration_tests::test_wasi_http_p3_hash_all

@fibonacci1729 fibonacci1729 merged commit 67a48b2 into spinframework:main Oct 27, 2025
17 checks passed
@fibonacci1729 fibonacci1729 deleted the wasip3-unstable branch October 27, 2025 16:48
@rancherbot rancherbot mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itowlson itowlson itowlson approved these changes

@lann lann Awaiting requested review from lann

@tschneidereit tschneidereit Awaiting requested review from tschneidereit

@dicej dicej Awaiting requested review from dicej

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require more explicit opt-in to unstable wasip3 executor

3 participants

@fibonacci1729 @lann @itowlson