This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(retrofit2): fix retrofit2 issues (backport #1875)#1876
Merged
mergify[bot] merged 1 commit intorelease-1.37.xfrom Feb 27, 2025
Merged
fix(retrofit2): fix retrofit2 issues (backport #1875)#1876mergify[bot] merged 1 commit intorelease-1.37.xfrom
mergify[bot] merged 1 commit intorelease-1.37.xfrom
Conversation
* test(retrofit2): add test to demonstrate the following error when QueryMap is used without generics: `java.lang.IllegalArgumentException: Map must include generic types (e.g., Map<String, String>)` * fix(retrofit2): fix non-generics QueryMap which causes the following error: `java.lang.IllegalArgumentException: Map must include generic types (e.g., Map<String, String>)` * fix(retrofit2): fix `A @path parameter must not come after a @Query` error (cherry picked from commit bdf8922)
dbyron-sf
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed the following two issues which occurred due to restrictions in retrofit2 :
This is an automatic backport of pull request fix(retrofit2): fix retrofit2 issues #1875 done by Mergify.