This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(web): make type of additionalFilters in ImageController.findImages#1877
Merged
mergify[bot] merged 2 commits intospinnaker:masterfrom Feb 27, 2025
Merged
Conversation
match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement.
jasonmcintosh
approved these changes
Feb 27, 2025
Member
jasonmcintosh
left a comment
jasonmcintosh
left a comment
There was a problem hiding this comment.
I'm good with going this route - another one should be java honestly.
Contributor
Author
Yup, the next step is converting ImageController to java. One day... |
Contributor
Author
|
@Mergifyio backport release-1.37.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
#1877) * test(web): demonstrate behavior of ImageController.findImages * fix(web): make type of additionalFilters in ImageController.findImages match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement. (cherry picked from commit 875a8b1)
mergify bot
added a commit
that referenced
this pull request
Feb 27, 2025
#1877) (#1878) * test(web): demonstrate behavior of ImageController.findImages * fix(web): make type of additionalFilters in ImageController.findImages match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement. (cherry picked from commit 875a8b1) Co-authored-by: David Byron <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement.
See #1875 (comment) for background.