This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(web): fix the mismatch in return types of EchoService.postEvent api stub and the actual api from echo#1885
Merged
mergify[bot] merged 2 commits intospinnaker:masterfrom Mar 3, 2025
Conversation
Contributor
kirangodishala
commented
Mar 3, 2025
kirangodishala
commented
- added a test to demonstrate the issue
- fixed the issue by correcting the return type of EchoService.postEvent api stub
…EchoService.postEvent api stub and the actual api from echo.
…pi stub and the actual api from echo.
dbyron-sf
approved these changes
Mar 3, 2025
Contributor
|
@Mergifyio backport release-1.37.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…pi stub and the actual api from echo (#1885) * test(web): add a test to demonstrate the mismatch in return types of EchoService.postEvent api stub and the actual api from echo. * fix(web): fix the mismatch in return types of EchoService.postEvent api stub and the actual api from echo. (cherry picked from commit ed77027)
mergify bot
added a commit
that referenced
this pull request
Mar 3, 2025
…pi stub and the actual api from echo (#1885) (#1886) * test(web): add a test to demonstrate the mismatch in return types of EchoService.postEvent api stub and the actual api from echo. * fix(web): fix the mismatch in return types of EchoService.postEvent api stub and the actual api from echo. (cherry picked from commit ed77027) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.