break: Handle codes not in the dictionary#230
Open
robert3005 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
AdamGS
approved these changes
Jun 24, 2026
AdamGS
left a comment
Contributor
There was a problem hiding this comment.
This seems like a reasonable fix, if there's a way to make this faster we can do it as a followup.
Contributor
|
If I try and decode with a symbol table and I encounter a code not in that table I should panic shouldn't I? But instead this will just proceed? |
Member
Author
|
not sure we should panic, we could offer a checked decompress that errors for symbols out of bounds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid performance penalty of checked accesses we always pad the symbols table to the max length. This will require a change in consumers to avoid serialising padded values
fixes #218