Add new config for acceptable matchers for ff and rb #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmelograno
requested changes
Sep 4, 2025
| @@ -74,7 +80,7 @@ func (e *Evaluator) evaluateTreatment(key string, bucketingKey string, featureFl | |||
| ctx.AddDependency("evaluator", e) | |||
| ctx.AddDependency("ruleBasedSegmentStorage", e.ruleBasedSegmentStorage) | |||
|
|
|||
| split := grammar.NewSplit(splitDto, ctx, e.logger) | |||
| split := grammar.NewSplit(splitDto, ctx, e.logger, grammar.NewRuleBuilder(ctx, e.segmentStorage, e.ruleBasedSegmentStorage, e.featureFlagRules, e.ruleBasedSegmentRules, e.logger)) | |||
There was a problem hiding this comment.
what about evaluator receiving the entire ruleBuilder instead of passing the config parameters and creating the ruleBuilder here?
There was a problem hiding this comment.
For this, we need to remove the context.
| @@ -14,8 +14,9 @@ func TestAllKeysMatcher(t *testing.T) { | |||
| dto := &dtos.MatcherDTO{ | |||
| MatcherType: "ALL_KEYS", | |||
| } | |||
| ruleBuilder := NewRuleBuilder(nil, nil, nil, SyncProxyFeatureFlagsRules, SyncProxyRuleBasedSegmentRules, logger) | |||
There was a problem hiding this comment.
what about matcher receive the rule builder so then you only call the BuildMatcher>
There was a problem hiding this comment.
This is a test. For rule-based segments, it's receiving a ruleBuilder and calling the method.
mredolatti
approved these changes
Sep 9, 2025
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GO SPLIT COMMONS
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes