Skip to content

[Custom InLocalStorage] Add storage.wrapper option for InLocal storage #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: inlocalstorage_baseline
Choose a base branch
from
Open

[Custom InLocalStorage] Add storage.wrapper option for InLocal storage #424

wants to merge 19 commits into from

Conversation

EmilianoSanchez
Copy link
Contributor

JavaScript commons library

What did you accomplish?

  • StorageAdapter to support sync and async storages

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez
Implement basic storageAdapter to support async storages with getItem…
4411c5d 
… and setItem methods
@EmilianoSanchez
Merge branch 'inlocalstorage_wrapper' into inlocalstorage_storageAdapter
6d0f274
@EmilianoSanchez
Tests
b550042
@EmilianoSanchez
Update types
4b0988d
@EmilianoSanchez
refactor: rename Storage interface to StorageWrapper for clarity and …
299585b 
…consistency
@EmilianoSanchez
Merge branch 'inlocalstorage_wrapper' into inlocalstorage_storageAdapter
2bcf4d4
@EmilianoSanchez
Revert "Break the PR into smaller PRs"
70ea6d4 
This reverts commit 96eaea0.
@EmilianoSanchez
Merge branch 'inlocalstorage_wrapper' into inlocalstorage_reorder_ope…
71258da 
…rations
@EmilianoSanchez
Merge branch 'inlocalstorage_reorder_operations' into inlocalstorage_…
47a8cc2 
…storageAdapter
@EmilianoSanchez
refactor: move storageAdapter to dedicated file and update imports
60aa25d
@EmilianoSanchez
Add unit test
cb22017
@EmilianoSanchez
optimize StorageAdapter's length and key methods by using arrays inst…
6bb2930 
…ead of object cache
@EmilianoSanchez
refactor: rename save method to whenSaved
a7d3246
@EmilianoSanchez
optimize StorageAdapter using an internal keys array and cache object
c594a6a
@EmilianoSanchez
refactor: split StorageWrapper into sync and async interfaces for bet…
a1c091b 
…ter type safety
@EmilianoSanchez
Revert commit 70ea6d4.
1c09903
@EmilianoSanchez
Add and use StorageAdapter::save method
afdf656
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner August 11, 2025 23:45
Base automatically changed from inlocalstorage_wrapper to inlocalstorage_baseline August 12, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilianoSanchez