-
Notifications
You must be signed in to change notification settings - Fork 6
[FME-12059] SDK_UPDATE with metadata #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ZamoraEmmanuel
wants to merge
6
commits into
development
Choose a base branch
from
fme-12059
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a719bb7
[FME-12059] SDK_UPDATE with metadata
ZamoraEmmanuel ef651cc
Fix types
ZamoraEmmanuel f4a6988
Update metadata properties
ZamoraEmmanuel 631366d
Move enum and type to namespace
ZamoraEmmanuel 6f054c9
Remove names when segments update
ZamoraEmmanuel c9795ea
avoid metadata when rbs update
ZamoraEmmanuel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/sync/polling/updaters/__tests__/segmentChangesUpdater.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { readinessManagerFactory } from '../../../../readiness/readinessManager'; | ||
| import { SegmentsCacheInMemory } from '../../../../storages/inMemory/SegmentsCacheInMemory'; | ||
| import { segmentChangesUpdaterFactory } from '../segmentChangesUpdater'; | ||
| import { fullSettings } from '../../../../utils/settingsValidation/__tests__/settings.mocks'; | ||
| import { EventEmitter } from '../../../../utils/MinEvents'; | ||
| import { loggerMock } from '../../../../logger/__tests__/sdkLogger.mock'; | ||
| import { ISegmentChangesFetcher } from '../../fetchers/types'; | ||
| import { ISegmentChangesResponse } from '../../../../dtos/types'; | ||
| import { SDK_SEGMENTS_ARRIVED } from '../../../../readiness/constants'; | ||
|
|
||
| describe('segmentChangesUpdater', () => { | ||
| const segments = new SegmentsCacheInMemory(); | ||
| const updateSegments = jest.spyOn(segments, 'update'); | ||
|
|
||
| const readinessManager = readinessManagerFactory(EventEmitter, fullSettings); | ||
| const segmentsEmitSpy = jest.spyOn(readinessManager.segments, 'emit'); | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| segments.clear(); | ||
| readinessManager.segments.segmentsArrived = false; | ||
| }); | ||
|
|
||
| test('test with segments update - should emit updatedSegments and NOT updatedFlags', async () => { | ||
| const segmentName = 'test-segment'; | ||
| const segmentChange: ISegmentChangesResponse = { | ||
| name: segmentName, | ||
| added: ['key1', 'key2'], | ||
| removed: [], | ||
| since: -1, | ||
| till: 123 | ||
| }; | ||
|
|
||
| const mockSegmentChangesFetcher: ISegmentChangesFetcher = jest.fn().mockResolvedValue([segmentChange]); | ||
|
|
||
| const segmentChangesUpdater = segmentChangesUpdaterFactory( | ||
| loggerMock, | ||
| mockSegmentChangesFetcher, | ||
| segments, | ||
| readinessManager, | ||
| 1000, | ||
| 1 | ||
| ); | ||
|
|
||
| segments.registerSegments([segmentName]); | ||
|
|
||
| await segmentChangesUpdater(undefined, segmentName); | ||
|
|
||
| expect(updateSegments).toHaveBeenCalledWith(segmentName, segmentChange.added, segmentChange.removed, segmentChange.till); | ||
| expect(segmentsEmitSpy).toBeCalledWith(SDK_SEGMENTS_ARRIVED, { updatedSegments: [segmentName] }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.