fix(validation): correct regexp validation for empty strings #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
approved these changes
Feb 20, 2025
|
Should we also add the SmartX UI tests to capture the actual behaviour - front-end and back-end validations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-78537
PR Type
What kind of change does this PR introduce?
Summary
Changes
Remove trim for string data as we do not do it on backend.
Correctly display error for invalid regexp expression. Full regexp displayed in error message instead of just first character.
User experience
UI validation reflects backend.
Checklist
If an item doesn't apply to your changes, leave it unchecked.