refactor: move config tabs method in GlobalConfig class #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hetangmodi-crest
requested review from
artemrys,
sgoral-splunk and
kkedziak-splunk
artemrys
changed the title
artemrys
changed the title
artemrys
requested changes
Feb 20, 2025
| @@ -122,16 +122,25 @@ def inputs(self) -> List[Any]: | |||
| return self._content["pages"]["inputs"]["services"] | |||
| return [] | |||
|
|
|||
| @property | |||
| def configuration(self) -> List[Any]: | |||
There was a problem hiding this comment.
hm, should this be tabs and the one config_tabs would be resolved_tabs?
There was a problem hiding this comment.
The name tabs was an ambiguous name for the method. The reason for naming it configuration is to maintain parity in global_config.py - since we have an input method (which returns input data) and a pages method (which returns page data), I thought to rename tabs to configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
ADDON-78036
PR Type
What kind of change does this PR introduce?
Summary
Made
config_tabs(which is a method inglobal_config_validator.py) as a part ofGlobalConfigclass.Changes
Made the
config_tabsmethod part of theGlobalConfigclass and renamed the previoustabsmethod in GlobalConfig toconfiguration.User experience
Checklist
If an item doesn't apply to your changes, leave it unchecked.