CSPL-4006: Replication port issue fix #1623
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue seemed to be that when customers use DefaultsURL or ConfigMap-based defaults, they rely entirely on those sources for replication port config, and if there's any timing issue, parsing problem, or configuration error in the user-provided defaults, the replication port won't be set, causing pod startup failures. This is due to the ordering of how we are checking for our default configuration
The replication_port config was missing from operator-managed default.yml. This would cause IndexerCluster pods to fail with "need to specify replication port".
This seemed to be a quite simple way to address this issue, and since 9887 is the designated default Splunk replication port, seemed to make sense to include as a part of the default config. Open to discussion on potential better solutions to this, however.
Key Changes
This proposed change is as minimal as I could think to do. Port 9887 is the designated default Splunk replication_port, so this seemed to be a reasonable add to the default.yaml that we create.
Testing and Verification
Was able to replicate issue locally and verified this fix can work.
Related Issues
PR Checklist