Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-5006: Http error handling fix and add retry #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pajk
Copy link
Collaborator

@Pajk Pajk commented Feb 18, 2025

Resolves #68
Closes #67


Based on PR #67

  • do the same but for more resources
  • make the linter happy

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

go test ./synthetics/... -run TestAccCreateUpdateApiCheckV2                               
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.470s
go test ./synthetics/... -run TestAccCreateUpdateBrowserCheckV2                             
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.410s
go test ./synthetics/... -run TestAccCreateDowntimeConfigurationV2
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.485s
go test ./synthetics/... -run TestAccCreateUpdateHttpCheckV2 
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.478s
go test ./synthetics/... -run TestAccCreateLocationV2                                    
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.431s
go test ./synthetics/... -run TestAccCreateUpdatePortCheckV2                       
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.298s
go test ./synthetics/... -run TestAccCreateUpdateVariableV2                              
ok      github.com/splunk/terraform-provider-synthetics/synthetics      0.312s

Does this introduce a breaking change?

  • Yes
  • No

@Pajk Pajk mentioned this pull request Feb 18, 2025
4 tasks
@Pajk Pajk changed the title Http error handling fix and add retry SYN-5006: Http error handling fix and add retry Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly removing resource state from state file on http error
2 participants