feat: add issue reaction methods and fix comment reaction template #250
+83
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add createIssueReaction() and deleteIssueReaction() methods - Fix COMMENTS_REACTION_ID_TEMPLATE to use correct comment endpoint - Add comprehensive tests for issue reaction functionality - Update deleteCommentReaction method signature to use commentId 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
javoire
commented
Jul 30, 2025
| @@ -260,14 +261,14 @@ public CompletableFuture<CommentReaction> createCommentReaction( | |||
| * href="https://docs.github.com/en/rest/reactions/reactions?apiVersion=2022-11-28#delete-an-issue-comment-reaction">List | |||
| * reactions for an issue comment</a> | |||
| * | |||
| * @param issueNumber the issue number | |||
| * @param commentId the comment id | |||
| * @param reactionId the reaction id | |||
| * @return a CompletableFuture containing the HTTP response | |||
| */ | |||
| public CompletableFuture<HttpResponse> deleteCommentReaction( | |||
There was a problem hiding this comment.
this one incorrectly deleted an issue reaction instead of an issue comment reaction, like the method name suggests
Leolebleis
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.