Skip to content

feat: github apps support - #3189

Open
klopfdreh wants to merge 1 commit into
spring-cloud:mainfrom
klopfdreh:feature/githubapps
Open

klopfdreh wants to merge 1 commit into
spring-cloud:mainfrom
klopfdreh:feature/githubapps

Conversation

@klopfdreh

@klopfdreh klopfdreh commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Fix for: #3188

Things need to be done before the feature is ready:

  • The dependencies have to be managed in a better way and also may exchanged with alt. integrations (jsonwebtoken / bouncycastle)
  • The Properties could be renamed and relocated to a Properties class
  • Proxy-Settings for RestTemplate setup should be improved
  • Tests should be implemented (if possible)

The config currently would look like this:

spring:
  cloud:
    config:
      server:
        git:
          uri: https://github.com/organization/my-config-server-repository
          username: x-access-token # used to authenticate with GitHub App access tokens
          password: |
            -----BEGIN RSA PRIVATE KEY
            ...
            -----END RSA PRIVATE KEY-----
          app: true # indicates that an app should be used
          appId: 530 # the id of the app
          apiUri: https://api.github.com/ # the GitHub api uri (might be changed for enterprise customers)
          installationId: 2164 # the app installation id
          jwtExpirationMinutes: 8 # how long the token is valid until a new one is retrieved

@klopfdreh
klopfdreh force-pushed the feature/githubapps branch 4 times, most recently from e7d0d74 to 95fd10f Compare February 9, 2026 10:02
@klopfdreh
klopfdreh marked this pull request as ready for review February 9, 2026 10:06
Signed-off-by: Tobias Soloschenko <tsoloschenko@apache.org>
@klopfdreh

Copy link
Copy Markdown
Contributor Author

@healer0805

Copy link
Copy Markdown

It looks cool

@spencergibb spencergibb moved this from Todo to In Progress in 2026.0.0-M1 Feb 17, 2026
@spencergibb spencergibb added this to the 5.1.0-M1 milestone Feb 17, 2026
@spencergibb

Copy link
Copy Markdown
Member

Funny, I started to review "Please extract these..." and I remembered, he had a list of "things to be done" and there it was, extract to properties! 🤣

@klopfdreh

klopfdreh commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

¯\_(ツ)_/¯

@klopfdreh

klopfdreh commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Just a small hint here - with JDK 27 PEMs can be decoded: https://openjdk.org/jeps/538 (third preview)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants