Skip to content

Uppercase static final constants #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Uppercase static final constants #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions complete-kotlin/src/main/kotlin/com/example/restservice/GreetingController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import org.springframework.web.bind.annotation.RestController
class GreetingController {

companion object {
private const val template = "Hello, %s!"
private const val TEMPLATE = "Hello, %s!"
}
private val counter = AtomicLong()

@GetMapping("/greeting")
fun greeting(@RequestParam name: String = "World") =
Greeting(counter.incrementAndGet(), String.format(template, name))
Greeting(counter.incrementAndGet(), String.format(TEMPLATE, name))

}
4 changes: 2 additions & 2 deletions complete/src/main/java/com/example/restservice/GreetingController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
@RestController
public class GreetingController {

private static final String template = "Hello, %s!";
private static final String TEMPLATE = "Hello, %s!";
private final AtomicLong counter = new AtomicLong();

@GetMapping("/greeting")
public Greeting greeting(@RequestParam(defaultValue = "World") String name) {
return new Greeting(counter.incrementAndGet(), String.format(template, name));
return new Greeting(counter.incrementAndGet(), String.format(TEMPLATE, name));
}
}