Trac 2265 one tag #292
Merged
Trac 2265 one tag #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehakraza
reviewed
May 20, 2025
| @@ -126,7 +129,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| function hasUserGrantedConsent() { | |||
| function hasUserDeclinedConsent() { | |||
| const consentedVendors = window.utag.data['cp.cmp_cv_list'] || window.utag.data['cp.cm_cv_list'] || ''; | |||
| const hasUserGivenConsent = consentedVendors.includes('adobe_analytics'); | |||
| const isAfterCMP = exportedFunctions.isAfterCMP(); | |||
There was a problem hiding this comment.
I'm curious why the function name is changed without changing the functionality. The return value still corresponds to if the user has granted consent or not.
…ed to make it more readable;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMP Layer changes in events added due to 2,5 way model.
One Adobe Page View Tag : I had to change number of current tag we use in Adobe.