SPR-20295 adding new types for non auth fetch and timeout #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derzierau
requested review from
fgerardwltn24,
daniel-krug,
a user and
eschmittel
derzierau
removed request for
fgerardwltn24,
daniel-krug,
a user and
eschmittel
derzierau
requested review from
fgerardwltn24,
a user,
eschmittel and
daniel-krug
ghost
approved these changes
Oct 4, 2022
| @@ -1,6 +1,6 @@ | |||
| import { TealiumData } from "./model"; | |||
| import { provide } from "./apiprovide"; | |||
There was a problem hiding this comment.
maybe you can rename the file to "apiProvide" ?
daniel-krug
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds types for the updated fetch functions of ps-whoami-web.
The type changes do not interfere current states of other applications.
We will add the possibility to customize time-outs for requests with fetch.
ps-whoami-web PR is still in DRAFT: https://github.com/spring-media/ps-whoami-web/pull/87